[EuiDataGrid] Use displayAsText for column sort search and columns headers
#4351
Conversation
If the `display` property isn't provided, then the column header should use the `displayAsText` property before falling back to `id`. Docs example now shows `Email address` while keeping `email` id, and other columns now capitalised.
Still uses `id` if `displayAsText` property not provided
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Regarding the CLA, I did this in my free time but in future I may contribute during work hours with this account. I shall sign the individual contributor agreement for now, as work may want me to use a different account anyway, but it may be worth adding an email field alongside the github username. |
j-m
changed the title
displayAsText for column sort search and columns headers
|
jenkins test this |
|
@j-m Thanks for the PR. A quick glance and your changes look good. You'll want to add a changelog for this. Here's a suggestion. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4351/ |
|
Thanks for the PR! |
|
Wow that was quick, you're very welcome! |
3 participants
Summary
displayAsTextcolumn prop as a heading ([EuiDataGrid]displayAsTextnot setting column names #4114). Will usedisplayoverdisplayAsText, anddisplayAsTextoverid.displayAsTextcolumn prop ([EuiDataGrid] Columns search does not match display text #4204). Will still useidifdisplayAsTextwas not provided.Before
After
Checklist
Other than changelog, I don't think any of these apply; I thought I'd wait for a review before editting the changelog. Should I add a test or two?